[server] accept requests where 'content' is missing entirely, not just null or empty#13521
Closed
andysalerno wants to merge 1 commit intoggml-org:masterfrom
Closed
[server] accept requests where 'content' is missing entirely, not just null or empty#13521andysalerno wants to merge 1 commit intoggml-org:masterfrom
andysalerno wants to merge 1 commit intoggml-org:masterfrom
Conversation
Collaborator
|
Looks good, but can you also check if google/minja#63 needs to be applied to fix this completely? |
ngxson
reviewed
May 14, 2025
Collaborator
|
@ngxson I think it's even more finegrained: only assistant role messages can contain either |
Collaborator
|
Per @ngxson comment ahove, added a pull request that checks for all the missing elements and produces meaningful error messages. |
Collaborator
|
Also @CISC , tested on my case and tool calling seems to work properly now, doesn't seem that integrating the minja fix is required. |
Collaborator
|
Superceded by #13540 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have encountered a problem very similar to #13471 .
That issue was fixed by allowing null or empty value for "content".
But my scenario (using pydantic-ai as a client) has requests where "content" is completely absent, in scenarios where there is a tool request.
If you look at the code for "at()" in json.hpp, you'll see it throws if the property is missing entirely.
This PR change fixed the issue for me locally.
Edit - here is an example of a message within a chat completions requests that has no content:
looks related to #13516